Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prometheus): added and impl metrics pusher to push metrics to prometheus pushgateway #4137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(prometheus): added and impl metrics pusher to push metrics to prometheus pushgateway #4137

wants to merge 1 commit into from

Conversation

Suyghur
Copy link
Contributor

@Suyghur Suyghur commented May 10, 2024 •
edited

help me to code review, plz~
@kevwan

@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (8690859) to head (b4641be).
Report is 49 commits behind head on master.

Additional details and impacted files

see 255 files with indirect coverage changes

@Suyghur Suyghur changed the title feat(prometheus): added and impl metrics pusher to push metrics to prometheus pushgateway feat(prometheus): added and impl metrics pusher to push metrics to prometheus pushgateway May 10, 2024
@kevwan
Copy link
Contributor

kevwan commented May 12, 2024

What's the purpose of this PR?

@Suyghur
Copy link
Contributor Author

Suyghur commented May 12, 2024 •
edited

What's the purpose of this PR?

  • In some scenarios, it is not convenient for the app to directly connect with the Prometheus server.
  • Some jobs have a short life cycle and do not have enough time to wait for Prometheus Server pull data. So you can push the data to Pushgateway first, and then let Prometheus Server pull it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Suyghur @kevwan