-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM architectures to Synology DSM7 #2169
base: dev
Are you sure you want to change the base?
Add ARM architectures to Synology DSM7 #2169
Conversation
There's a "small" issue: DSM doesn't support installing Docker on ARM64 |
@kleuter - hmm, I'm not so sure about that. I believe as of DSM7, DSM does support installing Docker (it's been renamed to "Container Manager") on ARM64 devices. I have a Synology p.s. Entirely up to you, of course, but it might be worth updating https://crystalidea.com/blog/zerotier-synology-arm-no-docker (one of the resources I initially found while trying to install ZeroTier on this particular device; thank you! 🎉) - bonus points (from me, of course), if you reference this PR to address the "Even if you manage to install Docker yourself (we failed), the official zerotier-synology image is amd64 only" limitation you mention. I'd love to see this PR merged in (and released to dockerhub) for exactly this reason. |
Thanks for the update, indeed, newer arm64 devices are supported, I updated the article mentioning your PR. |
Cool, thank you! Now, let's hope a maintainer of this repo takes a look at the PR, merges it in, and releases an update to dockerhub. 🙏 Bonus points if this could become part of the 'normal' release to dockerhub of all other images (though, I must admit, I didn't look to see how/where that is done or automated in this repo). |
@joseph-henry / @glimberg - when either of you have a moment, do you mind taking a look at this PR? 🙏 I'd love to see this get merged in (or, at the very least, some feedback to iterate upon 😉 ) so that there are some official arm tags on https://hub.docker.com/r/zerotier/zerotier-synology/tags |
Possibly Addresses
I think this may address #1873 & #1957 , possibly #2153 too, but unsure (not enough details in issue).
Testing
I have an example of this change published on my dockerhub account (https://hub.docker.com/repository/docker/chriscarini/zerotier-synology/general):
I've been running for ~15 days w/o any issues (according to the logs; see below):
I'd rather this be contributed back to the main project (i.e. https://github.com/zerotier/ZeroTierOne), and delete the image published to my personal DockerHub account.
Next Steps
After this PR is merged, someone w/ the respective permissions to the zerotier dockerhub would need to run the below command to get a new tag/version published out to DockerHub w/ the new architectures:
CC: @joseph-henry (who I believe first added the DSM7 packaging to this repo)