Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop searching on unresolved build config of associated build files #1744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Techatrix
Copy link
Member

This also reverts the change to the iteration order of #1738

#1629 should be reopened because the issue is in the logic that identifier if a file is associated with a build file.
These lines have been added in #863 which caused incorrect associations between file:

zls/src/DocumentStore.zig

Lines 1224 to 1226 in 3187c3d

if (try handle.getAssociatedBuildFileUri(self)) |associated_build_file_uri| {
return std.mem.eql(u8, associated_build_file_uri, build_file_uri);
}

This also reverts the change to the iteration order of #1738
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3187c3d) 75.72% compared to head (3902ad5) 75.75%.

Files Patch % Lines
src/DocumentStore.zig 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1744      +/-   ##
==========================================
+ Coverage   75.72%   75.75%   +0.03%     
==========================================
  Files          35       35              
  Lines       10212    10201      -11     
==========================================
- Hits         7733     7728       -5     
+ Misses       2479     2473       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant