Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: Make conversation arrow double as a go-to-conversation button. #30027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

N-Shar-ma
Copy link
Collaborator

The chevron arrow icon before the topic / dm user field now also acts as a go to conversation button. Whenever the functionality is available, the plain icon changes to look and behave like a button. The old go to conversation button on the right of the field is removed.

Fixes: #28697.

(Alternative to #28915)

Screenshots and screen captures:

When the go to conversation functionality isn't available:
Light:
image

Dark:
image

When it is available:
Light:
image
image

Dark:
image
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

The chevron arrow icon before the topic / dm user field now also acts as
a go to conversation button. Whenever the functionality is available,
the plain icon changes to look and behave like a button. The old go to
conversation button on the right of the field is removed.

Fixes: zulip#28697.
@zulipbot zulipbot added size: L area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. redesign Part of the webapp redesign project, including blockers. labels May 9, 2024
@zulipbot
Copy link
Member

zulipbot commented May 9, 2024

Hello @zulip/design members, this pull request was labeled with the "redesign" label, so you may want to check it out!

@timabbott timabbott added chat.zulip.org review Added by maintainers when a PR requires chat.zulip.org testing to proceed. area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. and removed area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. labels May 9, 2024
@alya
Copy link
Contributor

alya commented May 10, 2024

Works for me in manual testing! Posted a UX question on CZO.

@timabbott timabbott added the deployed on chat.zulip.org Added by maintainers when a PR is currently being tested on chat.zulip.org. label May 14, 2024
@timabbott
Copy link
Sponsor Member

Test-deploying on chat.zulip.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. chat.zulip.org review Added by maintainers when a PR requires chat.zulip.org testing to proceed. deployed on chat.zulip.org Added by maintainers when a PR is currently being tested on chat.zulip.org. redesign Part of the webapp redesign project, including blockers. size: L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign "go to conversation" button
4 participants