Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realm: Replace occurrences of uri with url in templates. #30029

Merged
merged 2 commits into from May 24, 2024

Conversation

Vector73
Copy link
Collaborator

@Vector73 Vector73 commented May 9, 2024

This PR is extracted from #29959 and reorganized to replace occurrences of URI with URL in:

  • send_email.py, email templates and some other related files
  • context_processors.py file and related templates

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@Vector73
Copy link
Collaborator Author

Vector73 commented May 9, 2024

I have manually tested some of the updated templates for both commits.

@timabbott
Copy link
Sponsor Member

I addressed the translation tests by:

  • Updating the locale data to still have a translation for that email.
  • Made sure Transifex has the translation updates so this doesn't break when we next sync from there.

With those changes, looks good, merged, thanks @Vector73!

Vector73 and others added 2 commits May 24, 2024 10:54
This commit replaces occurrences of realm_uri with realm_url in email templates
and other related backend files.

Co-authored-by: Junyao Chen <junyao.chen@socitydao.org>
This commit replaces occurrences of realm_uri with realm_url in
"context_processors.py" and related templates.

With by-hand translation updates for German (also updated in
Transifex) to avoid breaking the i18n system tests that use some
modified strings.

Co-authored-by: Junyao Chen <junyao.chen@socitydao.org>
@timabbott
Copy link
Sponsor Member

Fixed the tests properly this time, including a PROVISION_VERSION bump because we need compilemessages to have been run with the right strings.

@timabbott timabbott merged commit fef3161 into zulip:main May 24, 2024
6 checks passed
@Vector73 Vector73 deleted the uri_to_url-3 branch May 25, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants