Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left_sidebar: Rename "more topics" to "all topics" #30033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kuv2707
Copy link
Collaborator

@kuv2707 kuv2707 commented May 9, 2024

This PR replaces the occurrences of "more topics" to "all topics" in comments and documentation.

Fixes #30014

Screenshots and screen captures:

Screenshots

image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: S area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers priority: high labels May 9, 2024
@alya
Copy link
Contributor

alya commented May 14, 2024

We are replacing the /why-zulip screenshot soon, so Iet's skip it for this PR.

@kuv2707
Copy link
Collaborator Author

kuv2707 commented May 16, 2024

@alya Done.

@timabbott
Copy link
Sponsor Member

@kuv2707 can you switch this to "show all topics"? After seeing this, I think that's what we want to test.

@kuv2707
Copy link
Collaborator Author

kuv2707 commented May 17, 2024

@timabbott done.

This commit renames the occurrences of "more topics"
to "all topics" in comments and documentation.

Fixes zulip#30014
@zulipbot
Copy link
Member

Heads up @kuv2707, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers has conflicts priority: high size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "more topics" to "all topics" in left sidebar
4 participants