css: Fix theme switch changing color of elements at different intervals. #30040
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timabbott
reviewed
May 10, 2024
| @@ -115,7 +115,6 @@ input::placeholder { | |||
| box-shadow: none; | |||
|
|
|||
| cursor: pointer; | |||
| transition: all 0.2s ease; | |||
There was a problem hiding this comment.
So this is on a broad button element; do you know why we had this transition declared?
There was a problem hiding this comment.
timabbott
reviewed
May 10, 2024
| @@ -111,7 +108,6 @@ | |||
| /* Main geometry for this element is in zulip.css */ | |||
| #compose-content { | |||
| background-color: hsl(232deg 30% 92%); | |||
| transition: background-color 200ms linear; | |||
There was a problem hiding this comment.
Do you know why we had this transition declared on the compose box? I was wondering if it's an open/close animation, or for preview, or something else?
There was a problem hiding this comment.
Due to these transitions the theme switch from dark <-> light was not pleasant as the background color and color changed at different intervals.
amanagr
force-pushed
the
fix_theme_switcher
branch
from
386aa8e
to
482414f
Compare
|
Merged, thanks @amanagr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to these transitions the theme switch from dark <-> light was not pleasant as the background color and color changed at different intervals.
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/theme.20transition