Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 29655: Page reloads on hitting enter key while moving message over topics #30052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sar-thak-3
Copy link
Collaborator

Fixes: #29655

Screenshots and screen captures:

Changes

The problem arose from the form's default behavior, which causes the page to reload when the Enter key is pressed. To address this, I implemented functionality to handle the Enter key press specifically when the move message dialog box is active. This ensures that the form can be submitted without reloading the page, while other key presses are ignored.

Self-review checklist
  • [ x] Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • [ x] Explains differences from previous plans (e.g., issue description).
  • [ x] Highlights technical choices and bugs encountered.
  • [ x] Calls out remaining decisions and concerns.
  • [ x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • [ x] Each commit is a coherent idea.
  • [ x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • [x ] Visual appearance of the changes.
  • [ x] Responsiveness and internationalization.
  • [ x] Strings and tooltips.
  • [ x] End-to-end functionality of buttons, interactions and flows.
  • [ x] Corner cases, error conditions, and easily imagined bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting the enter key in the move message(s) dialog reloads the page
2 participants