Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the local time from the personal menu #30054

Closed
wants to merge 1 commit into from

Conversation

Smnthjm08
Copy link
Collaborator

@Smnthjm08 Smnthjm08 commented May 10, 2024

Fixes:

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@timabbott
Copy link
Sponsor Member

@sayamsamal can you review as our popovers maintainer?

@Smnthjm08 Smnthjm08 closed this May 14, 2024
@sayamsamal
Copy link
Collaborator

Hey @Smnthjm08, I see this is now closed. Any reason for doing so? If you are planning on creating a new PR then do tag me for a quick review. :)

@Smnthjm08 Smnthjm08 reopened this May 16, 2024
@Smnthjm08 Smnthjm08 closed this May 16, 2024
@Smnthjm08
Copy link
Collaborator Author

yeah i will create new pull request, sure i will tag you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants