Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent_view: Complete TODO to use first unmuted unread message id. #30060

Merged
merged 3 commits into from May 20, 2024

Conversation

amanagr
Copy link
Member

@amanagr amanagr commented May 11, 2024

We already had the data at initial request, so we just add some plumbing to make it available.

Followup to #30008 (comment)

Copy link

sentry-io bot commented May 11, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: web/src/ui_init.js

Function Unhandled Issue
initialize_everything Error: Unknown user_id in get_by_user_id: 713675 ...
Event Count: 5 Affected Users: 2
initialize_everything Error: Unknown user_id in get_by_user_id: 715094 ...
Event Count: 1 Affected Users: 18
initialize_everything TypeError: p()("input.stream-list-filter").expectOne is not a function. (In 'p()("input.stream-list-filter")... ...
Event Count: 1 Affected Users: 2
initialize_everything ReferenceError: ResizeObserver is not defined com...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@@ -86,7 +86,7 @@ export function changehash(newhash, trigger) {
browser_history.set_hash(newhash);
}

export function save_narrow(terms, trigger) {
export function set_hash_to_filter_terms(terms, trigger) {
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update_hash_to_match_filter would be a better name? And then maybe we should just pass filter, trigger as the parameters?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, updated!

We already had the data at initial request, so we just add
some plumbing to make it available.
@timabbott timabbott merged commit 7d41c8c into zulip:main May 20, 2024
4 of 5 checks passed
@timabbott
Copy link
Sponsor Member

Merged, after moving one hunk to the last commit.

I don't love the implementation; I worry about those math.min operations being slow, and didn't really want more complexity in the individual unread.ts code paths. But it should work, and we can always refactor later, and I don't want to block getting the basic logic changes to production in a correct way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants