Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent-conversations: Not completely rerender for a single message #30066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lumpleme
Copy link
Collaborator

Updates recent_view_ui.process_messages to have a check before rerendering, so rerendering one single message can be done with inplace_rerender instead of complete_rerender.

Fixes: #23638

…message

Updates recent_view_ui.process_messages to have a check before rerendering, so rerendering one single message can be done with inplace_rerender instead of complete_rerender.
@zulipbot
Copy link
Member

Hello @lumpleme, it seems like you have referenced #23638 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #23638..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

Copy link

sentry-io bot commented May 13, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: web/src/recent_view_ui.js

Function Unhandled Issue
process_messages RangeError: Invalid time value get_localized_date...
Event Count: 33 Affected Users: 51
process_messages RangeError: date value is not finite in DateTimeFormat format() update_load_more_banner(src/...
Event Count: 5 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

Comment on lines -445 to +451
complete_rerender();
if (messages.length === 1) {
// inplace_rerender for a single message
const topic_key = recent_view_util.get_key_from_message(messages[0]);
inplace_rerender(topic_key);
} else {
complete_rerender();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to modify inplce_rerender fix the current position of the topic.

@zulipbot
Copy link
Member

Heads up @lumpleme, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize rerendering of recent conversations for single message events.
3 participants