Rename "display_settings" to "preferences" in web folder #30067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Could you please update your commit messages to match the commit style guidelines? |
Someone12543
commented
May 15, 2024
There was a problem hiding this comment.
I have made a mistake, as I tried to change a commit message's description but accidentally commented here instead.
I am now editing this comment so it's not non-sensical.
I do not fully know how to edit commit messages through the github app, so I'll sift and find out how to do it through the terminal.
Someone12543
force-pushed
the
issue-26874-renameusersettings
branch
from
a471f17
to
6e6f65a
Compare
|
Making progress, I got this. |
I started by identifying the different types of "display_settings" and their references, all according to an earlier message in this issue (zulip#26874) from Tim Abbot. After analyzing the code for a solid few hours I determined that there were 3: a constant variable defined in server_events_dispatch.js; a few dictionaries in different files along with a filename; and a file named user_display_settings.hbs. Regarding this specific commit, I just had find all instances of the user_display_settings variable that wasn't the user_display_settings.hbs, and since all those instances were inside the web folder, I didn't have to worry about coupling issues, so all instances were simply changed to user_preferences.
Someone12543
force-pushed
the
issue-26874-renameusersettings
branch
2 times, most recently
from
5f444ca
to
920ea56
Compare
Finding all references to the 'display_settings' was a little hard due to my lack of extensive front-end knowledge, but I toughed it out through 3 different commits designed for the same purpose. This commit was previously 3 commits, so they were sqaushed for better readability and coherence. Once again these changes were all isolates to the web folder so no coupling issues to worry about.
This was by far the easiest commit, as I just changed a file name and it's singular reference in the settings tab list, which were both in the web folder so no coupling problems.
Someone12543
force-pushed
the
issue-26874-renameusersettings
branch
from
920ea56
to
aa573a4
Compare
|
Wow, very messy over here... But I think I solved all issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aptly renamed all instances of "display_settings" to "preferences" inside the web folder, as mentioned through an earlier message from timabbott that included a git grep command. Intended to solve all mentioned instances of "display_settings" in that same message.
Fixes part of: #26874
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: