-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typeahead: Make them look like dropdown widget. #30072
base: main
Are you sure you want to change the base?
Conversation
c5d03f8
to
ab46bc1
Compare
Actually, similarly for "(Notify channel)" / "(Notify topic)", and playground languages. It seems like a good approach to take for all the parentheticals in these typeaheads. If it's non-trivial, we can pull that out into a separate issue or PR. |
It's helpful to these all alongside each other! |
The purplish text looks too faded to me, but I'm happy to try it out on CZO and see what other folks think. @terpimost FYI |
I played with the PR and didn't have any other feedback. |
Since @terpimost's feedback is on improvements (not regressions in the current PR), addressing these points isn't a blocker for CZO deployment. @timabbott FYI |
The space on the left issue noted in #30072 (comment) is the main thing that I kinda want fixed before this goes to production. |
Test-deploying on chat.zulip.org |
Hm, I don't quite follow the last set of before/after screenshots. The idea was just to remove the blank space on the left for the typeaheads that don't have an icon there (slash commands, languages, topics). |
I updated the screenshots for last 2 to help do a proper comparison, but I reduced left padding from 20px to 10px for all the typeaheads while making sure typeaheads with user presence circle don't break. We also use the same left padding in our stream selector dropdown in compose box, so I think it will work well. |
d85c34f
to
6b00bc0
Compare
This attempts to change background color and text color of typeaheads to be same as dropdown widgets we have in the app.
This required taking special care of typeaheads with user circle and making sure long typeaheads wrap correctly.
Updated deployment of this on chat.zulip.org. |
This attempts to change background color and text color of typeaheads to be same as dropdown widgets we have in the app.
active
typeahead color was taken from https://terpimost.github.io/compose-decomposed/Related issue - #25116
This PR is to help us get the colors we want for the typeaheads, then we can do some of the much needed cleanup work in this space.
Here is a list of all typeaheads:
@
,#
,/
, ....Search (No change)
Playground settings > Language - http://localhost:9991/#organization/playground-settings