Chenge uri for url #30073
Closed
Chenge uri for url #30073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hash_util.search_terms_to_hash` doesn't work correctly for all hashes, main one being the combined feed view.
Now, user can use browser back button to go their last selected message in combined feed view.
This is no longer required since narrow state is restored by `reload` library and narrow history restores the narrow pointer and offset when going back to a view. Only regression here is we will no longer restore the pointer when user navigates to the combined feed view without using browser back button and combined feed view is the default view. This is fixed in the next commit.
If user goes to combined feed view on escape keypress, then we restore their narrow pointer and offset by restoring it from browser history if the their last narrow was the combined feed view.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
As of commit 7b00bd6, this no longer exists. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Commit 90d0531 (zulip#23721) removed envelope-link and data-admin-emails. Signed-off-by: Anders Kaseorg <anders@zulip.com>
The messages populated in the test database are random in nature, so there is a possibility of more than one resolved topic messages returned by 'self.get_and_check_messages()' query in 'test_get_messages_for_resolved_topics'. That would result in a flaky behavior. This commit fixes the flaky behavior.
The messages populated in the test database are random in nature, so there is a possibility of any number of messages in 'new_stream_announcements_stream' in 'test_merge_streams'. Earlier, the test was assuming of exactly one message in that stream. That would result in a flaky behavior. This commit fixes the flaky behavior.
The reactions added to messages in the test database are random in nature, so there is a possibility of any number of reaction records in the exported user data. The test now verifies the reaction which was added in the test itself. Earlier, the test was assuming the reaction added in the test is the only record in the exported data. That would result in a flaky behavior. This commit fixes the flaky behavior.
We no longer create the 'core team' private channel when a realm is created. Earlier, "New user announcements" channel was set to the "core team" channel. Now it is disabled by default. populate_db still creates the 'core team' channel to represent a private channel.
Mark the channel name of the initial channel created during realm creation for translation. It doesn't mark the topic names and description for translation because we are planning to remove these topics and update the description as a part of improving the onboarding experience.
As a part of improving onboarding experience, this commit updates the channels and messages initially available in new orgs. Fixes zulip#29297.
This commit adds API documentation for "/users/me/apns_device_token:post" and "/users/me/apns_device_token:delete" endpoints. openapi: Document android_gcm_reg_id endpoints. Co-authored-by: Suyash Vardhan Mathur <suyash.mathur@research.iiit.ac.in>
This commit adds API documentation for "/users/me/android_gcm_reg_id:post" and "/users/me/android_gcm_reg_id:delete" endpoints. Co-authored-by: Suyash Vardhan Mathur <suyash.mathur@research.iiit.ac.in>
When the request to mark a thread as unread fails, we should use the value of include_anchor that was sent in the request, not false. Modified handle_mark_unread_from_here_error to take an object instead of parameters.
With combined feed no longer cached, this test became flaky as it took longer for combined feed to load. Verified that other tests waiting on `.message-list` don't need this change.
It depends libarrow1600, which is missing from the PGroonga repository on Debian 12. Signed-off-by: Anders Kaseorg <anders@zulip.com>
The function is used for any type of onboarding step i.e. not limited to Hotspot. This commit updates the function and variables name to reflect the above mentioned behaviour.
Earlier, hotspots and one-time notices were the valid type of onboarding step. Now, one-time notice is the only valid type. Fixes zulip#29296.
We keep fetching until we reach first unread message or have 50k messages worth of data displayed once user hits `Load more` in recent view.
Reproducer: * Go to a stream narrow. * Scroll up to select a previous message. * Click on a different stream in the left sidebar. * Click browser back button, you land at first unread message instead of your selected message. Fixed by updating the hash before we render the new message list.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Instead of applying 'remove_single_newlines()' to individual contents when declared, we use it once while prepping up message in 'internal_prep_stream_message_by_name'. Just for the code to be less finnicky.
- Tighten up the content. - Use pretty quotes. - Reorder "experiments" topic to appear after "start a conversation" in Inbox. - Drop reference to messages being starred (not implemented yet).
This will let us properly call it from compose_closed_ui without a full message object, which we need to convert it to typescript.
|
Heads up @RodPeroba, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Closing in favor of #29959, which is a PR for this same issue. Check out our GitHub guide and commit guidelines before making your next PR -- it looks like you're having some trouble with Git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: