Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: Determine the prearm check results #27049

Conversation

muramura
Copy link
Contributor

The results of the first pre-arm check have not been verified.
It is better to judge the pre-arm check result and check the next pre-arm check.

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, in this case that change in wrong.
We first test the motor configuration through the arming check.
Whatever the result is, if we got Torqeedo esc, we test it.

With your change we won't report Torqeedo start until we fix first the motor configuration.

So the current way is better as we report as much as we can in a single loop. This is possible as the check independant

@khancyr
Copy link
Contributor

khancyr commented Jun 3, 2024

Thanks anyway, but I will close this one as that isn't a good change.

@khancyr khancyr closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants