Updating binding tests to test single column #13656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
changed the title
adrinr
requested review from
mike12345567,
samwho and
a team
and removed request for
a team
samwho
approved these changes
May 10, 2024
samwho
approved these changes
May 10, 2024
adrinr
force-pushed
the
budi-8123/test-singleuser-binding
branch
from
0bde020
to
01036dc
Compare
adrinr
commented
May 13, 2024
adrinr
force-pushed
the
budi-8123/test-singleuser-binding
branch
2 times, most recently
from
facf218
to
00dabe9
Compare
adrinr
changed the base branch from
feat/budi-8123-single-user
to
budi-8123/fix-binding-panel
adrinr
changed the base branch from
budi-8123/fix-binding-panel
to
feat/budi-8123-single-user
adrinr
force-pushed
the
budi-8123/test-singleuser-binding
branch
from
5dec4bd
to
01b9d60
Compare
mike12345567
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix broken test after merging master into the feature branch. Changed to actually test the new single user column type.
With the recent changes, user column will be always treated as a list, so some filters such as
equalare not valid anymore. Also added tests to ensure that the deprecated config is still supported