feat: Allow users to enable session replay during product analytics onboarding #22339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -40 B (0%) Total Size: 1.05 MB ℹ️ View Unchanged
|
|
Not sure why the experiments test keeps failing @neilkakkar @jurajmajerik , am I missing something? |
xrdt
commented
May 17, 2024
| ] | ||
|
|
||
| if (featureFlags[FEATURE_FLAGS.ENABLE_SESSION_REPLAY_PA_ONBOARDING]) { | ||
| options.push({ |
There was a problem hiding this comment.
Should we also enable console logs, network performance?
There was a problem hiding this comment.
yep iirc the default in replay is console logs and "performance" opt in, not headers or body capture
pauldambra
approved these changes
May 17, 2024
timgl
pushed a commit
that referenced
this pull request
May 21, 2024
…nboarding (#22339) * flag toggle to enable session replay during pa onboarding * turn on console log, network perf by default
thmsobrmlr
pushed a commit
that referenced
this pull request
May 21, 2024
…nboarding (#22339) * flag toggle to enable session replay during pa onboarding * turn on console log, network perf by default
Comment on lines
+65
to
+81
| ...configOptions | ||
| .filter((option) => option.visible) | ||
| .map((option) => ({ | ||
| title: option.title, | ||
| description: option.description, | ||
| type: option.type as ConfigType, | ||
| selectOptions: option.selectOptions, | ||
| value: option.value, | ||
| onChange: (newValue: boolean | string | number) => { | ||
| // Use the current value from the ref to ensure that onChange always accesses | ||
| // the latest state of configOptions, preventing the closure from using stale data. | ||
| const updatedConfigOptions = configOptionsRef.current.map((o) => | ||
| o.teamProperty === option.teamProperty ? { ...o, value: newValue } : o | ||
| ) | ||
| setConfigOptions(updatedConfigOptions) | ||
| }, | ||
| })), |
There was a problem hiding this comment.
@zlwaterfield when we move to a single subscribe, we should make sure people are aware of the potential costs here when enabling replay from analytics onboarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The toggle is gated behind a 50% flag. https://us.posthog.com/project/2/experiments/33719
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?