Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pre-release patches toggle #1785

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

feat: Pre-release patches toggle #1785

wants to merge 7 commits into from
+237 −20

Conversation

kitadai31
Copy link
Contributor

@kitadai31 kitadai31 commented Mar 25, 2024 •
edited

Add a toggle for pre-release patches to the alternative source settings.
Closes: #821

This PR also fixes an problem where pre-release Integrations are being used when using alternate sources.
At this time, Patches are referring GitHubAPI#getLatestPatchesRelease() that doesn't include pre-releases, but Integrations are referring GitHubAPI#getLatestRelease() that includes pre-releases.
This problem actually caused patched apps to crash recently in crimera/piko patches (an alternative source) when they released a pre-releases.
(Actually, this is the main motivation)

getLatestReleaseFile() in github_api.dart was removed because it's unused

@Ushie
Copy link
Member

Ushie commented Mar 25, 2024

Why limit it to alternative sources?

You can pass ?dev=true to achieve the same with the ReVanced API

@oSumAtrIX
Copy link
Member

Are changelogs/updates considered as well?

@Ushie I am not sure but are queries ignored by cache on CloudFlare? Because then, using the dev query has no effect.

@kitadai31
Copy link
Contributor Author

kitadai31 commented Mar 25, 2024 •
edited

I already tried ?dev=true at ReVanced API, but it didn't effect.
https://api.revanced.app/v2/revanced-patches/releases/latest?dev=true
So, I thought it wasn't implemented yet.
That's why I limited to GitHub API only. I didn't know the cache issue.

If the cache issue will be fixed, I think I should wait for it.

Are changelogs/updates considered as well?

Yes. These lines change the data source of patches update dialog according to the settings.

revanced-manager/lib/ui/views/home/home_viewmodel.dart

Lines 482 to 490 in e88e997

Future<Map<String, dynamic>?> getLatestPatchesRelease() {
if (_managerAPI.isUsingAlternativeSources() &&
_managerAPI.isUsingPrereleasePatches()) {
return _githubAPI
.getLatestReleaseWithPreReleases(_managerAPI.getPatchesRepo());
} else {
return _githubAPI.getLatestRelease(_managerAPI.getPatchesRepo());
}
}

@TheAabedKhan TheAabedKhan linked an issue Apr 14, 2024 that may be closed by this pull request
feat: add feature/setting to pick pre-release patches instead #1867
Open
3 tasks
@brian6932
Copy link

brian6932 commented Apr 16, 2024 •
edited

One thing I noticed after building this branch (rebased) was that checking for Revanced Manager updates gets stuck on Loading..., patches work fine though. Is that just a quirk of debug builds, or an issue with the PR?

@validcube validcube linked an issue Apr 18, 2024 that may be closed by this pull request
feat: allow dev channel patches #821
Open
4 tasks
@nivranaitsirhc
Copy link

One thing I noticed after building this branch (rebased) was that checking for Revanced Manager updates gets stuck on Loading..., patches work fine though. Is that just a quirk of debug builds, or an issue with the PR?

Can you share the apk here please

@brian6932
Copy link

brian6932 commented Apr 20, 2024 •
edited by oSumAtrIX

@nivranaitsirhc sure [redacted]

@nivranaitsirhc
Copy link

nivranaitsirhc commented Apr 20, 2024 •
edited by oSumAtrIX

@nivranaitsirhc sure [redacted]

It works like a charm! Thanks!

Screenshot_20240420-191932_ReVanced Manager Debug.png

Screenshot_20240420-191959_ReVanced Manager Debug.png

Screenshot_20240420-193744_ReVanced Manager Debug.png

Screenshot_20240420-194113_YouTube.png

@kitadai31 kitadai31 mentioned this pull request Apr 21, 2024
Closed
@kitadai31
Merge remote-tracking branch 'origin/dev' into feat/prerelease-patches2
e8c63e6 
# Conflicts:
#	lib/services/github_api.dart
#	lib/services/manager_api.dart
#	lib/ui/views/home/home_viewmodel.dart
@kitadai31
fix fetching pre-release logic
47c411b 
If there are multiple dev releases on the same day, they will be sorted by alphabetically. Therefore, releases[0] is not guaranteed to be the latest.
vX.X.X-dev.10 will be older than vX.X.X-dev.9
so we have to iterate several releases and find the latest
@kitadai31
support ReVanced API
1b25454
@kitadai31
improve wording
cb0106d
@kitadai31
improve string
40b1589
@kitadai31 kitadai31 marked this pull request as draft May 14, 2024 09:30
@kitadai31
Copy link
Contributor Author

Waiting for the parameter issue in ReVanced API to be fixed

I have some questions

  1. I added the ReVanced API v2 related logic in revanced_api.dart, but should I split the file into two files like revanced_api_v2.dart ?
  2. I added a word "(dev)" in settings description because ReVanced calls pre-release versions “dev”. (40b1589)
    Is this no problem?

@kitadai31
improve string: add "if available" to the description
d740d31 
If the stable version is newer than the most recent pre-release, then the stable version will be used, so make it clear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add feature/setting to pick pre-release patches instead feat: allow dev channel patches
5 participants
@kitadai31 @Ushie @oSumAtrIX @brian6932 @nivranaitsirhc