Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pre-release patches toggle #1785

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kitadai31
Copy link
Contributor

@kitadai31 kitadai31 commented Mar 25, 2024

Add a toggle for pre-release patches to the alternative source settings.
Closes: #821

This PR also fixes an problem where pre-release Integrations are being used when using alternate sources.
At this time, Patches are referring GitHubAPI#getLatestPatchesRelease() that doesn't include pre-releases, but Integrations are referring GitHubAPI#getLatestRelease() that includes pre-releases.
This problem actually caused patched apps to crash recently in crimera/piko patches (an alternative source) when they released a pre-releases.
(Actually, this is the main motivation)

getLatestReleaseFile() in github_api.dart was removed because it's unused

@Ushie
Copy link
Member

Ushie commented Mar 25, 2024

Why limit it to alternative sources?

You can pass ?dev=true to achieve the same with the ReVanced API

@oSumAtrIX
Copy link
Member

Are changelogs/updates considered as well?

@Ushie I am not sure but are queries ignored by cache on CloudFlare? Because then, using the dev query has no effect.

@kitadai31
Copy link
Contributor Author

kitadai31 commented Mar 25, 2024

I already tried ?dev=true at ReVanced API, but it didn't effect.
https://api.revanced.app/v2/revanced-patches/releases/latest?dev=true
So, I thought it wasn't implemented yet.
That's why I limited to GitHub API only. I didn't know the cache issue.

If the cache issue will be fixed, I think I should wait for it.

Are changelogs/updates considered as well?

Yes. These lines change the data source of patches update dialog according to the settings.

Future<Map<String, dynamic>?> getLatestPatchesRelease() {
if (_managerAPI.isUsingAlternativeSources() &&
_managerAPI.isUsingPrereleasePatches()) {
return _githubAPI
.getLatestReleaseWithPreReleases(_managerAPI.getPatchesRepo());
} else {
return _githubAPI.getLatestRelease(_managerAPI.getPatchesRepo());
}
}

@brian6932
Copy link

brian6932 commented Apr 16, 2024

One thing I noticed after building this branch (rebased) was that checking for Revanced Manager updates gets stuck on Loading..., patches work fine though. Is that just a quirk of debug builds, or an issue with the PR?

@validcube validcube linked an issue Apr 18, 2024 that may be closed by this pull request
4 tasks
@nivranaitsirhc
Copy link

One thing I noticed after building this branch (rebased) was that checking for Revanced Manager updates gets stuck on Loading..., patches work fine though. Is that just a quirk of debug builds, or an issue with the PR?

Can you share the apk here please

@brian6932
Copy link

brian6932 commented Apr 20, 2024

@nivranaitsirhc sure [redacted]

@nivranaitsirhc
Copy link

nivranaitsirhc commented Apr 20, 2024

@nivranaitsirhc sure [redacted]

It works like a charm! Thanks!

Screenshot_20240420-191932_ReVanced Manager Debug.png

Screenshot_20240420-191959_ReVanced Manager Debug.png

Screenshot_20240420-193744_ReVanced Manager Debug.png

Screenshot_20240420-194113_YouTube.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add feature/setting to pick pre-release patches instead feat: allow dev channel patches
5 participants