Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve documentation #1411

Draft
wants to merge 50 commits into
base: compose-dev
Choose a base branch
from
Draft

docs: Improve documentation #1411

wants to merge 50 commits into from

Conversation

validcube
Copy link
Member

@validcube validcube commented Oct 21, 2023

Guide to use the application will be seperate from this PR

Split

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Axelen123 Axelen123 added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Oct 31, 2023
@Axelen123 Axelen123 mentioned this pull request Nov 3, 2023
3 tasks
@Axelen123
Copy link
Member

@validcube what is the status of this PR?

@validcube
Copy link
Member Author

@validcube what is the status of this PR?

All of the essential are done (consistency with other ReVanced repository might not be guaranteed); I'm separating additional documentation changes into another PR so that this PR won't get locked up.

Copy link
Contributor

@KobeW50 KobeW50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize I had to start the review. Thought it was pending cuz i don't have perms

docs/developers/1_overview.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
validcube and others added 2 commits November 8, 2023 22:19
Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
This commit removes the developer version, preventing this PR from being locked up with additional developer experiences.
Continuing the legacy of Vanced
</p>

# 👋 Contribution guidelines
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Contribution guidelines" or "ReVanced Manager contribution guidelines"

the second one is consistent with ReVanced Patches repository

https://github.com/ReVanced/revanced-patches/blob/docs/CONTRIBUTING.md#-revanced-patches-contribution-guidelines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the second one

@validcube validcube marked this pull request as ready for review November 8, 2023 15:31

Co-authored-by: Palm <palmpasuthorn@gmail.com>
@validcube validcube marked this pull request as draft November 8, 2023 15:42
@validcube validcube dismissed PalmDevs’s stale review November 8, 2023 16:43

Staled; also outdated

@validcube validcube mentioned this pull request Nov 11, 2023
@Axelen123
Copy link
Member

What is the status of this?

It might make sense to split out the README and contribution guidelines into a separate PR if the other documentation will take time to finish

@validcube validcube marked this pull request as ready for review December 9, 2023 14:35
@validcube
Copy link
Member Author

validcube commented Dec 9, 2023

Guide to use compose-dev + developer will be seperate from this PR.

This PR will only improve general documentation like README.md and CONTRIBUTING.md, but include changes like spellcheck in other areas.

merge changes from `dev` (flutter)
Comment on lines +7 to 8
<!-- What happen to this? @BenjaminHalko -->
3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still incomplete

@@ -12,7 +12,6 @@ This documentation explains how to use [ReVanced Manager](https://github.com/rev
3. [🔄 Updating ReVanced Manager](2_3_updating.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating has been implemented. The file is out of date (It is also not showing up in the github review page for some reason!)


We provide the some of the features are:

* 📱 **Portable**: ReVanced Patcher that fit in your pocket;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds kinda weird. What does "portable" mean here and how is it beneficial?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds kinda weird. What does "portable" mean here and how is it beneficial?

I have to generate 4 compelling points or reasons to use the ReVanced Manager 💀

Any suggestion would be great.

Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen some consistency errors with our other repositories while skimming through this PR. It would be a good idea first to restore this consistency and then apply the change consistently across all involved repositories. An example of an inconsistency is that other repositories have an "About" section, such as ReVanced CLI, or the merge difference in language and wording.

Apart from that, there are some unfinished sections that already have been commented on as well as the patching page, which features no more note blocks about warnings and pitfalls. It may be a good idea to incorporate them if applicable to restore completeness.

@oSumAtrIX oSumAtrIX changed the title docs: improve documentation docs: Improve documentation Jan 22, 2024
@oSumAtrIX oSumAtrIX marked this pull request as draft January 22, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants