Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build): refresh #1521

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

ci(build): refresh #1521

wants to merge 16 commits into from

Conversation

validcube
Copy link
Member

@validcube validcube commented Nov 24, 2023

Copy link
Contributor

⚒️ ReVanced PR Build workflow

✅ ReVanced Manager 81a8671 build succeeded.

Checkout the Dart static analyze check at job summary.

Directly download the application artifact here.

⚙️ Overview

  • App flavor: release
  • Branch: stable
  • Compile arguments:
  • Start time: Sat, 25 Nov 2023 02:41:54 +0000

@validcube validcube self-assigned this Nov 26, 2023
Copy link
Member

@PalmDevs PalmDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the question I added in the review.

.github/workflows/pr-build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 1, 2023

⚒️ ReVanced PR Build workflow

✅ ReVanced Manager bdc282f build succeeded.

Checkout the Dart static analyze check or download the artifact at job summary.

⚙️ Overview

  • App flavor: release
  • Branch: stable
  • Compile arguments:

Copy link
Member

@PalmDevs PalmDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, not required though.

path: |
build/app/outputs/flutter-apk/app-${{ inputs.app-flavor }}.apk
build/app/outputs/flutter-apk/app-${{ inputs.app-flavor }}.apk.sha1

- name: "Comment to Pull Request #${{ inputs.pr-number }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this step comment as @revanced-bot?

Copy link
Member Author

@validcube validcube Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this step comment as @revanced-bot?

This was mentioned in the initial pull request for ci(build), this suggestion depends on the repository manager which is out of my limit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repository manager being who? @oSumAtrIX can you look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants