fix: Replace Spacer with Expanded to avoid overflow #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was supposed to actually mention #1790 |
4 tasks
validcube
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
## [1.19.4-dev.3](v1.19.4-dev.2...v1.19.4-dev.3) (2024-03-28) ### Bug Fixes * Replace Spacer with Expanded to avoid overflow ([#1791](#1791)) ([6f70a07](6f70a07))
validcube
deleted the
1790-bug-the-button-is-out-of-place-if-the-title-is-long
branch
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
# [1.20.0](v1.19.3...v1.20.0) (2024-04-05) ### Bug Fixes * disable proguard obfuscation ([401646a](401646a)) * Do not crash when selecting an APK from storage ([#1768](#1768)) ([8564c1a](8564c1a)) * Don't translation ReVanced repository ([c265794](c265794)) * Ensure safe area usage in Changelogs Modal Bottom Sheet ([#1772](#1772)) ([c981cb4](c981cb4)) * Pre-releases changelog being shown ([#1767](#1767)) ([add49e1](add49e1)) * Replace Spacer with Expanded to avoid overflow ([#1791](#1791)) ([6f70a07](6f70a07)) * Set text colour on dropdown menu for Custom Value ([966796d](966796d)), closes [#1584](#1584) * **ui:** Support free-scroll and auto-scroll for the installer logs ([#1736](#1736)) ([#1836](#1836)) ([025ff52](025ff52)) ### Features * Improve language update settings ([#1838](#1838)) ([f9e6ef3](f9e6ef3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team are going to make a joke now
, 44 hours on decoration for a 10 seconds change
馃槉 Issue
@MarcaDian created an issue with our source switcher regarding the
[AlertDialog][title]being too long and caused the[IconButton]to overflowed out of the view here:The relevant code was line 30-40 in Settings Fragment - Manage Sources
revanced-manager/lib/ui/views/settings/settingsFragment/settings_manage_sources.dart
Lines 30 to 40 in c209c32
[Spacer]tried to take up all the remaining space after those two widgets (Text & IconButton) by default it will take one yade yada (I hope I'm right) - tl;dr: we basically have very limited space - now obviously as you can see in #1790 that ended up being a failure, so what I do is we switch to[Expanded]which surprisingly works a lot better... (well yeah no sh-)馃敡 Testing note
Testing was done in "simulated" environment, which means I didn't edit ReVanced Manager code, but I recreated it in some online editor, specifically DartPad which work super well in my opinion.
20240327_123737.mp4
(It's encoded using HEVC, you might need additional setup, deal with it
)
fix: #1790