Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update dialog shows dev version & loading gets stuck in certain circumstances #1792

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

fix: Update dialog shows dev version & loading gets stuck in certain circumstances #1792

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88bdde0
fix: Update dialog shows dev version & stuck loading in certain circu…
kitadai31 Mar 27, 2024
3715e04
fix: Use latestManagerVersion field value in update dialog
kitadai31 Mar 31, 2024
2b4b0ee
build: Update Dart dependencies
validcube May 19, 2024
4631ceb
🔮 Merge repository updated to latest snapshot!
validcube May 19, 2024
60e1fb6
chore: Resolve even more conflict
validcube May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 27 additions & 19 deletions lib/services/github_api.dart
View file
Open in desktop
Expand Up @@ -77,29 +77,37 @@ class GithubAPI {
final response = await _dio.get(
'/repos/$repoName/releases',
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final response = await _dio.get(
'/repos/$repoName/releases',
);
final response = await _dio.get(
'/repos/$repoName/releases?per_page=100',
);
final List<dynamic> releases =
response.data.where((release) => !release['prerelease']).toList();
int updates = 0;
final String currentVersion =
await _managerAPI.getCurrentManagerVersion();
while (releases[updates]['tag_name'] != currentVersion) {
updates++;
if (updates == releases.length) {
break;
}
}
for (int i = 1; i < updates; i++) {
releases[0].update(
'body',
(value) =>
value +
'\n' +
'# ' +
releases[i]['tag_name'] +
'\n' +
releases[i]['body'],
);
}
return releases[0];

final Map<String, dynamic> releases = response.data[0];
int updates = 0;
final List<dynamic> releases = response.data;
int latestReleaseIndex =
releases.indexWhere((element) => element['prerelease'] == false);
if (latestReleaseIndex == -1) {
latestReleaseIndex = 0;
}
final Map<String, dynamic> release = releases[latestReleaseIndex];
final String currentVersion =
await _managerAPI.getCurrentManagerVersion();
while (response.data[updates]['tag_name'] != currentVersion) {
updates++;
}
for (int i = 1; i < updates; i++) {
if (response.data[i]['prerelease']) {
continue;
if (release['tag_name'] != currentVersion) {
// Append previous changelogs
for (int i = latestReleaseIndex + 1; i < releases.length; i++) {
if (releases[i]['tag_name'] == currentVersion) {
break;
}
if (releases[i]['prerelease']) {
continue;
}
release.update(
'body',
(value) =>
value +
'\n' +
'# ' +
releases[i]['tag_name'] +
'\n' +
releases[i]['body'],
);
}
releases.update(
'body',
(value) =>
value +
'\n' +
'# ' +
response.data[i]['tag_name'] +
'\n' +
response.data[i]['body'],
);
}
return releases;
return release;
} on Exception catch (e) {
if (kDebugMode) {
print(e);
Expand Down