-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stochastic matmul verify #1134
Open
andrej
wants to merge
7
commits into
Xilinx:main
Choose a base branch
from
andrej:matmul-verify-stochastic
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stochastic matmul verify #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this still a WIP or ready to merge? |
Let me rebase this on refactor-matmul. Then, once refactor-matmul is merged, we can merge this if you are cool with it |
andrej
force-pushed
the
matmul-verify-stochastic
branch
4 times, most recently
from
April 3, 2024 19:48
b62eca6
to
47c796f
Compare
andrej
force-pushed
the
matmul-verify-stochastic
branch
from
April 5, 2024 17:43
47c796f
to
ffbc54a
Compare
This also contains the fixes for the verification code on the host ( |
jgmelber
reviewed
Apr 5, 2024
…; fix variable naming
jgmelber
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.