Supply more unique UUIDs for PDIs in aie2xclbin #1163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erieaton-amd
force-pushed
the
fix-pdi-uuid
branch
from
91fb074
to
0408d48
Compare
| @@ -441,7 +441,7 @@ static LogicalResult generateXCLBin(MLIRContext *context, ModuleOp moduleOp, | |||
| openOutputFile(aiePartitionJsonFile, &errorMessage); | |||
| if (!aiePartitionJsonOut) | |||
| return moduleOp.emitOpError(errorMessage); | |||
|
|
|||
| uint64_t time = std::chrono::high_resolution_clock::now().time_since_epoch().count(); | |||
There was a problem hiding this comment.
Would hashing the design be more reasonable?
There was a problem hiding this comment.
In aiecc.py we use a random int with a small range, which is not super collision resistant. Maybe hash the time plus the design? So that parallel builds (same time) or rebuilds of the same design (e.g. after a fix) don't collide?
Windows driver expects these values to actually be unique, it causes a problem if you try to create multiple hardware contexts for multiple xclbins.
erieaton-amd
force-pushed
the
fix-pdi-uuid
branch
from
0408d48
to
d7fbe32
Compare
|
|
Should we not actually generate a uuid / guid by making a call such as RPC_STATUS status = UuidCreate(&uuid); |
|
Obsoleted by #1513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows driver expects these values to actually be unique, it causes a problem if you try to create multiple hardware contexts for multiple xclbins.