Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xllvm] Add support for multi-result intrinsics #1470

Merged
merged 1 commit into from
May 21, 2024

Conversation

jsetoain
Copy link
Collaborator

@jsetoain jsetoain commented May 8, 2024

This patch enables external LLVM intrinsics with multiple results, and adds llvm.aie2.vmax.ltbf16 as a test case.

@jsetoain
Copy link
Collaborator Author

jsetoain commented May 8, 2024

I'll be adding the tests shortly, but I wanted to give you a heads-up.

@jsetoain jsetoain force-pushed the add-multi-result-intrinsics branch 2 times, most recently from de62a46 to c31a495 Compare May 10, 2024 07:06
Copy link
Collaborator

@jamestcl-amd jamestcl-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

include/aie/Dialect/XLLVM/IR/XLLVMAIE2IntrOps.td Outdated Show resolved Hide resolved
@jsetoain jsetoain added this pull request to the merge queue May 13, 2024
@jsetoain jsetoain removed this pull request from the merge queue due to a manual request May 13, 2024
@jsetoain jsetoain force-pushed the add-multi-result-intrinsics branch from c31a495 to 35ce0dd Compare May 21, 2024 09:46
@jsetoain jsetoain enabled auto-merge May 21, 2024 09:46
@jsetoain jsetoain added this pull request to the merge queue May 21, 2024
Merged via the queue into Xilinx:main with commit 92c6ed9 May 21, 2024
51 checks passed
@jsetoain jsetoain deleted the add-multi-result-intrinsics branch May 21, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants