-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing improvements #1492
Open
andrej
wants to merge
8
commits into
Xilinx:main
Choose a base branch
from
andrej:more-tracing
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tracing improvements #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrej
requested review from
makslevental,
jackl-xilinx and
jgmelber
as code owners
May 16, 2024 00:19
Can you make it work on https://github.com/Xilinx/aie-rt/blob/main-aie/driver/src/events/xaie_events_aieml.h? I think those are the aie2 events. |
Good catch, fixed it. I got lucky that the event numbers were mostly the same between AIE1 and 2 but was clearly using the wrong header file |
Looks like there are some tests that need updating. I will look into this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the tracing utilities in
python/utils/trace.py
as well as the tracing parse scripts inprogamming_examples/utils
.python/utils/trace_events_enum.py
contains an enumeration of all available tracing events. This is automatically generated from this header file in aie-rt using the newutils/generate_events_enum.py
script.Please let me know what you think.