This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Add commandline switch to disable Electron disk cache for HTTP requests. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy merging this with |
sanohin
suggested changes
Feb 11, 2019
cli/src/athenapdf.js
Outdated
| @@ -46,6 +46,7 @@ athena | |||
| .option("--no-cache", "disables caching") | |||
| .option("--ignore-certificate-errors", "ignores certificate errors") | |||
| .option("--ignore-gpu-blacklist", "Enables GPU in Docker environment") | |||
| .option("--disable-http-cache", "Disables Electron disk cache for HTTP requests.") | |||
There was a problem hiding this comment.
I agree that it would be better to make disable electron cache with --no-cache option instead of introducing a new one.
|
I updated pull request, now disk cache disabled with same --no-cache option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to disable Electron disk cache, for example - when we generating jpg-thumbnails for inclusion in pdf. I have added new athenapdf commandline switch --disable-http-cache which is similar to Electron.