Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Add commandline switch to disable Electron disk cache for HTTP requests. #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add commandline switch to disable Electron disk cache for HTTP requests. #177

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b004de0
Add commandline switch to disable Electron disk cache for HTTP requests.
Sep 11, 2018
3cd203f
Merge branch 'master' into master
alexxwiz Jul 15, 2020
c936b3a
Merge branch 'arachnys:master' into master
alexxwiz Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions cli/src/athenapdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ athena
.option("--no-cache", "disables caching")
.option("--ignore-certificate-errors", "ignores certificate errors")
.option("--ignore-gpu-blacklist", "Enables GPU in Docker environment")
.option("--disable-http-cache", "Disables Electron disk cache for HTTP requests.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would be better to make disable electron cache with --no-cache option instead of introducing a new one.

.arguments("<URI> [output]")
.action((uri, output) => {
uriArg = uri;
Expand Down Expand Up @@ -104,6 +105,10 @@ if (athena.ignoreCertificateErrors) {

app.commandLine.appendSwitch('ignore-gpu-blacklist', athena.ignoreGpuBlacklist || "false");

if (athena.disableHttpCache) {
app.commandLine.appendSwitch("disable-http-cache");
}

// Preferences
var bwOpts = {
show: (athena.debug || false),
Expand Down