Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designate kfp python package as optional dependency #3144

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akchinSTC
Copy link
Member

Closes #3139

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC added component:build build and build related issues(dependencies and docker) status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Apr 3, 2023
@akchinSTC akchinSTC added this to the 4.0.0 milestone Apr 3, 2023
@akchinSTC akchinSTC marked this pull request as draft April 3, 2023 16:18
@ptitzler ptitzler added the impact:breaking change Delivery introduces a change that is not backward compatible label Apr 3, 2023
"kfp>=1.7.0,<2.0,!=1.7.2", # We cap the SDK to <2.0 due to possible breaking changes
"typing-extensions>=3.10,<5", # Cap from kfp
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might remove the newline here, small nitpicking by me

@shalberd
Copy link

shalberd commented Apr 30, 2024

Testing this, the changes from the PR, out. Currently, still getting, due to kfp not present (no module named kfp).

I did make package-ui, make build-dependencies and make build-server and then installed the wheel file with the option [gitlab] instead of [all] or [kfp-tekton] as I am only using airflow with Elyra. It is working in the sense that I now no longer have kfp in pip list ...

https://elyra.readthedocs.io/en/stable/getting_started/installation.html#packaging

So now I have a python environment with no kfp python package anymore, so far, so good. Except:

0 00:24:08.592 ServerApp] Error loading schemas for SchemasProvider 'code-snippets' - No module named 'kfp'
[E 2024-04-30 00:24:08.593 ServerApp] Error loading schemas for SchemasProvider 'component-catalogs' - No module named 'kfp'
[E 2024-04-30 00:24:08.594 ServerApp] Error loading schemas for SchemasProvider 'runtimes' - No module named 'kfp'
[E 2024-04-30 00:24:08.595 ServerApp] Error loading schemas for SchemasProvider 'runtimes-images' - No module named 'kfp'
[W 2024-04-30 00:24:08.595 ServerApp] The following schemaspaces have no schemas: ['code-snippets', 'runtimes', 'runtime-images']

https://github.com/elyra-ai/elyra/blob/main/elyra/metadata/schema.py#L260

There would probably need to be a way to remove the hard-coded kfp runtime from RuntimeProcessorType enum https://github.com/kevin-bates/elyra/blob/main/elyra/pipeline/runtime_type.py#L25

Cause there is a difference between active runtimes from the config we all know and installed runtimes that then make a problem once kfp is not installed anymore.

I get my hunch from @kevin-bates https://github.com/elyra-ai/elyra/pull/2263/files#diff-2cb56468c742ac4f0ea118665f54e0424289b6cf4fd47233342eebd08034a889

@harshad16 what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) impact:breaking change Delivery introduces a change that is not backward compatible status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make kfp dependency in elyra-server packaging optional
3 participants