Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designate kfp python package as optional dependency #3144

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Designate kfp python package as optional dependency #3144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffdd833
Defer processor loading until runtimes are determined
akchinSTC Mar 31, 2023
dbf1a49
Move kfp into optional dependencies
akchinSTC Mar 31, 2023
f87c52e
Move other dep into kfp optional
akchinSTC Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion elyra/pipeline/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def __init__(self, **kwargs):
for processor in entrypoints.get_group_all("elyra.pipeline.processors"):
try:
# instantiate an actual instance of the processor
processor_instance = processor.load()(root_dir=self.root_dir, parent=kwargs.get("parent"))
if not self.runtimes or processor.name in self.runtimes:
processor_instance = processor.load()(root_dir=self.root_dir, parent=kwargs.get("parent"))
self._add_processor(processor_instance)
else:
self.log.info(
Expand Down
10 changes: 8 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,11 @@ dependencies = [
"rfc3986-validator>=0.1.1",
"tornado>=6.1.0",
"traitlets>=4.3.2",
"typing-extensions>=3.10,<5", # Cap from kfp
"typing-extensions>=3.10",
"urllib3>=1.26.5",
"watchdog>=2.1.3",
"websocket-client",
"yaspin",
"kfp>=1.7.0,<2.0,!=1.7.2", # We cap the SDK to <2.0 due to possible breaking changes
"pygithub",
"black>=22.8.0",
]
Expand Down Expand Up @@ -85,6 +84,11 @@ test = [
"requests-unixsocket",
"kfp-tekton"
]
kfp = [
"kfp>=1.7.0,<2.0,!=1.7.2", # We cap the SDK to <2.0 due to possible breaking changes
"typing-extensions>=3.10,<5", # Cap from kfp
]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might remove the newline here, small nitpicking by me

kfp-tekton = [
"kfp-tekton>=1.5.2" # requires kfp >= 1.8.19, which contains fix for Jupyterlab
]
Expand All @@ -96,9 +100,11 @@ gitlab = [
]
# The following is a collection of "non-test" extra dependencies from above.
all = [
"kfp>=1.7.0,<2.0,!=1.7.2", # We cap the SDK to <2.0 due to possible breaking changes
"kfp-tekton>=1.5.2",
"elyra-examples-kfp-catalog",
"python-gitlab",
"typing-extensions>=3.10,<5", # Cap from kfp
]

# Console scripts
Expand Down