Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.21] Fix eds cluster loadassignment with invalid endpoint #50720

Merged
merged 2 commits into from Apr 29, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Apr 28, 2024

Please provide a description of this PR:

fixes: #50718

Manual pick: #49629 and #50690

@zirain zirain requested a review from a team as a code owner April 28, 2024 03:03
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2024
…#49629)

* move port name and labels check outside of filterIstioEndpoint

* fix slices filter

* fix ut
* fix eds cluster has invalid endpoints

* Add release note

* Fix specical case ep address empty

* add uds addr check

* use IsValidIP
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2024
@istio-testing istio-testing merged commit a276ce8 into istio:release-1.21 Apr 29, 2024
28 checks passed
@zirain zirain deleted the fix/50718 branch April 29, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants