Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cards,router): Remove duplicated card number interface #4404

Merged
merged 5 commits into from May 16, 2024
Merged

refactor(cards,router): Remove duplicated card number interface #4404

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d2b90a
refactor(cards,router): Remove duplicated card number interface
yongjoon-km Apr 21, 2024
09cac91
Merge branch 'main' into deprecate-duplicated-card-interface
yongjoon-km Apr 23, 2024
297035d
Merge branch 'main' into deprecate-duplicated-card-interface
yongjoon-km Apr 23, 2024
8e0145c
Merge branch 'main' into deprecate-duplicated-card-interface
yongjoon-km Apr 23, 2024
2a64bad
Merge branch 'main' into deprecate-duplicated-card-interface
SanchithHegde May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/api_models/src/payment_methods.rs
View file
Open in desktop
Expand Up @@ -379,7 +379,7 @@ impl From<CardDetailFromLocker> for payments::AdditionalCardInfo {
card_isin: item.card_isin,
card_extended_bin: item
.card_number
.map(|card_number| card_number.get_card_extended_bin()),
.map(|card_number| card_number.get_extended_card_bin()),
card_exp_month: item.expiry_month,
card_exp_year: item.expiry_year,
card_holder_name: item.card_holder_name,
Expand Down
4 changes: 0 additions & 4 deletions crates/cards/src/validate.rs
View file
Open in desktop
Expand Up @@ -24,7 +24,6 @@ impl CardNumber {
pub fn get_card_isin(self) -> String {
self.0.peek().chars().take(6).collect::<String>()
}

pub fn get_extended_card_bin(self) -> String {
self.0.peek().chars().take(8).collect::<String>()
}
Expand All @@ -42,9 +41,6 @@ impl CardNumber {
.rev()
.collect::<String>()
}
pub fn get_card_extended_bin(self) -> String {
self.0.peek().chars().take(8).collect::<String>()
}
}

impl FromStr for CardNumber {
Expand Down
2 changes: 1 addition & 1 deletion crates/router/src/core/payments/helpers.rs
View file
Open in desktop
Expand Up @@ -3623,7 +3623,7 @@ pub async fn get_additional_payment_data(
match pm_data {
api_models::payments::PaymentMethodData::Card(card_data) => {
let card_isin = Some(card_data.card_number.clone().get_card_isin());
let card_extended_bin = Some(card_data.card_number.clone().get_card_extended_bin());
let card_extended_bin = Some(card_data.card_number.clone().get_extended_card_bin());
let last4 = Some(card_data.card_number.clone().get_last4());
if card_data.card_issuer.is_some()
&& card_data.card_network.is_some()
Expand Down