New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cards,router): Remove duplicated card number interface #4404
base: main
Are you sure you want to change the base?
refactor(cards,router): Remove duplicated card number interface #4404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yongjoon-km, thanks for the PR!
Can you remove the get_card_extended_bin()
function instead (keep get_extended_card_bin()
). This is to ensure consistent naming of the extended card bin
across the codebase.
I will change to use |
d2027aa
to
9bba816
Compare
9bba816
to
7d2b90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yongjoon-km LGTM! Please create and link an Issue to fix the failing CI check.
Hey @yongjoon-km, just so you're aware, you don't need to repetitively merge |
Oh.. I didn't know that. Thank you. |
Type of Change
Description
The CardNumber interface has a duplicated method with the same functionality. Removed one.
closes #4442
Additional Changes
Motivation and Context
How did you test it?
The methods get_extended_card_bin() and get_card_extended_bin() are identical and thus redundant. It is recommended to keep one and remove the other to avoid confusion.
Checklist
cargo +nightly fmt --all
cargo clippy