Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extendedwatercannons special world property #3365

Merged
merged 18 commits into from
May 31, 2024

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Apr 15, 2024

Added extendedwatercannons special world property, that allows the maximum number of water cannons to be extended at the same time. I set the new limit to 30 because that number seems to be enough, perhaps even too much.

image

Thanks to @Merlin for help with crashes

Resolved #3315

Add extendedwatercannons special world property
@Dark-Dragon
Copy link
Contributor

Would there be any disadvantage to just increasing this limit by default? I don't think this is a case where the limited default behavior is desirable at all, therefore being able to toggle between the two seems rather unnecessary to me.

@FileEX
Copy link
Contributor Author

FileEX commented Apr 16, 2024

Would there be any disadvantage to just increasing this limit by default? I don't think this is a case where the limited default behavior is desirable at all, therefore being able to toggle between the two seems rather unnecessary to me.

The same can be said about vegetation (randomfoliage) and underwater creatures - toggle them seems unnecessary, but you can toggle them anyway. I believe we can set this property to enabled by default, but I still think leaving the option to disable it isn't a bad thing. It is better when the user has choice and freedom than predefined settings that he cannot change.

In addition, it seems to me that few people really need an increased limit. In 12 years of playing, I never even noticed that such a limit even existed, and no one had ever reported it before.

@Dark-Dragon
Copy link
Contributor

Well there could be had a conversation about what the reasons might be it wasn't reported in the first place, but having it on by default seems like a fine compromise. Still I wouldn't be surprised if it will take more than 12 years for someone to specifically need to disable it, whereas I can see scenarios where foliage and water creatures could be desired or undesired. I'm just thinking the special world properties are slowly starting to get rather crowded, but that's not for me to decide, so I just want to point it out whenever I can.

@FileEX
Copy link
Contributor Author

FileEX commented Apr 16, 2024

I think it's good that we get new world properties. Thanks to this, server creators on MTA have more and more freedom and more opportunities. If someone doesn't want foliages, they can disable it, if someone doesn't want flipped cars to burn, they can disable this property. The same in this case, if for some reason someone really does not need such a limit extension, then disable this property. I think it's better to have this option than not to have it.

@Lpsd
Copy link
Member

Lpsd commented May 23, 2024

Please fix conflicts and we can merge this

@FileEX
Copy link
Contributor Author

FileEX commented May 23, 2024

Please fix conflicts and we can merge this

Done

@lopezloo
Copy link
Member

I think this limit should be increased by default.

@FileEX
Copy link
Contributor Author

FileEX commented May 28, 2024

I think this limit should be increased by default.

As you can see bff7007

The limit is increased by default

Client/game_sa/CGameSA.h Outdated Show resolved Hide resolved
Client/game_sa/CGameSA.h Outdated Show resolved Hide resolved
Shared/sdk/net/bitstream.h Show resolved Hide resolved
Shared/sdk/net/bitstream.h Outdated Show resolved Hide resolved
Shared/sdk/net/SyncStructures.h Outdated Show resolved Hide resolved
Shared/sdk/net/SyncStructures.h Outdated Show resolved Hide resolved
Shared/sdk/net/SyncStructures.h Outdated Show resolved Hide resolved
Shared/mods/deathmatch/logic/Enums.h Outdated Show resolved Hide resolved
Shared/sdk/net/bitstream.h Outdated Show resolved Hide resolved
@botder botder merged commit 13a5395 into multitheftauto:master May 31, 2024
6 checks passed
@botder botder added the enhancement New feature or request label May 31, 2024
@botder botder added this to the 1.6.1 milestone May 31, 2024
MTABot pushed a commit that referenced this pull request May 31, 2024
13a5395 Add extendedwatercannons special world property (PR #3365)
@FileEX FileEX deleted the feature/extendedwatercannons branch May 31, 2024 16:52
MegadreamsBE pushed a commit to MegadreamsBE/mtasa-blue that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only 3 water cannons on Fire Truck can be used at the same time
5 participants