Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for improve yurthub cache #1614

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JameKeal
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind design

What this PR does / why we need it:

  1. Sorting out the original architecture logic, identifying problems and proposing solutions
  2. Optimized architectural design, weakened YurtHub cloud-side two patterns code design

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind design

What this PR does / why we need it:

  1. Sorting out the original architecture logic, identifying problems and proposing solutions
  2. Optimized architectural design, weakened YurtHub cloud-side two patterns code design

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.68%. Comparing base (7fe6fd6) to head (2240828).
Report is 159 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
+ Coverage   51.42%   51.68%   +0.26%     
==========================================
  Files         134      218      +84     
  Lines       15947    26521   +10574     
==========================================
+ Hits         8200    13707    +5507     
- Misses       7001    11574    +4573     
- Partials      746     1240     +494     
Flag Coverage Δ
unittests 51.68% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JameKeal
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added size/L size/L: 100-499 and removed size/XL size/XL: 500-999 labels Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

@stale
Copy link

stale bot commented Oct 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 24, 2023
@Congrool
Copy link
Member

@JameKeal @rambohe-ch
Disscussion summary of weekly meeting at 2023.07.26.

  1. Add metrics for cache, like failed times, data size, etc. @rambohe-ch
  2. Original atomic ReplaceComponentList operation is replaced with multiple operations(like update, add, delete) in this proposal which is not atomic. Considering the case that yurthub is doing such "multiple operations" to cache the list response but failed by crash, the cached data on disk is incompleted and after restoring of yurthub it will use the incomplete data to serve client requests. The situation will not be relieved until the client sends a relist request and the yurthub sucessfully caches the new responses. @Congrool
  3. The underlayer of the Store interface may be diskStorage or etcdStorage. If the interface is modified, the implementation of etcdStorage should also be aligned with it. @Congrool

Copy link

stale bot commented Feb 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 24, 2024
@stale stale bot closed this Mar 2, 2024
@rambohe-ch rambohe-ch reopened this Mar 4, 2024
@rambohe-ch rambohe-ch removed the wontfix label Mar 4, 2024
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design kind/design size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants