Do not try to delete runner if script already running #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdr
approved these changes
Mar 29, 2024
enescakir
force-pushed
the
runner-register-idempotemt
branch
from
f2c8b87
to
8171c1a
Compare
velioglu
approved these changes
Apr 3, 2024
We catch Octokit::Conflict exception with the "Already exists" message
to ensure the `register_runner` function is idempotent. If it's run a
second time, it fails with this exception.
Recently, we found a few examples with non-idempotent results. If this
label run again after the start of the script, it fails with the
following error:
Failed to start transient service unit: Unit runner-script.service
already exists
This PR fixes this issue by checking if the script is already running
before trying to delete the runner.
enescakir
force-pushed
the
runner-register-idempotemt
branch
from
8171c1a
to
3e3b820
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We catch Octokit::Conflict exception with the "Already exists" message to ensure the
register_runnerfunction is idempotent. If it's run a second time, it fails with this exception.Recently, we found a few examples with non-idempotent results. If this label run again after the start of the script, it fails with the following error:
This PR fixes this issue by checking if the script is already running before trying to delete the runner.