Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to delete runner if script already running #1412

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Do not try to delete runner if script already running #1412

merged 1 commit into from
Apr 30, 2024

Commits on Apr 26, 2024

  1. Do not try to delete runner if script already running 

    We catch Octokit::Conflict exception with the "Already exists" message
to ensure the `register_runner` function is idempotent. If it's run a
second time, it fails with this exception.

Recently, we found a few examples with non-idempotent results. If this
label run again after the start of the script, it fails with the
following error:

    Failed to start transient service unit: Unit runner-script.service
    already exists

This PR fixes this issue by checking if the script is already running
before trying to delete the runner.
    @enescakir
    enescakir committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3e3b820 View commit details
    Browse the repository at this point in the history