Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SERVICE_NAME with inline string in the runner prog #1419

Merged
merged 1 commit into from Apr 30, 2024
Merged

Replace SERVICE_NAME with inline string in the runner prog #1419

merged 1 commit into from Apr 30, 2024

Conversation

enescakir
Copy link
Member

It's referenced rarely, and it makes harder to read.

@enescakir enescakir requested review from fdr and byucesoy April 2, 2024 22:36
@enescakir enescakir self-assigned this Apr 2, 2024
@enescakir enescakir mentioned this pull request Apr 2, 2024
Merged
fdr
fdr approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@fdr fdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-2 lines 😎

(also yeah, it doesn't form much of a fixed point/coupling with anything else in the program)

Base automatically changed from runner-register-idempotemt to main April 30, 2024 07:14
@enescakir
Replace SERVICE_NAME with inline string in the runner prog
4d62bb5 
It's referenced rarely, and it makes harder to read.
@enescakir enescakir merged commit 1756660 into main Apr 30, 2024
6 checks passed
@enescakir enescakir deleted the runner-script branch April 30, 2024 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fdr fdr fdr approved these changes

@byucesoy byucesoy byucesoy approved these changes

Assignees

@enescakir enescakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enescakir @fdr @byucesoy