fix libcuda_dirs import for triton 3.0 #227
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-vi Oh cool thanks! Did not notice the changes in Triton v3! Let me install the dev branch and check it out :) |
carmocca
reviewed
Mar 9, 2024
| triton_version = triton.__version__.split(".") | ||
| triton_major = int(triton_version[0]) | ||
| if triton_major >= 3: | ||
| from triton.backends.nvidia.driver import libcuda_dirs |
There was a problem hiding this comment.
This didn't work for me with pytorch-triton==3.0.0+901819d2b6:
import unsloth
File "/home/carmocca/git/unsloth/unsloth/__init__.py", line 64, in <module>
from triton.backends.nvidia.driver import libcuda_dirs
ImportError: cannot import name 'libcuda_dirs' from 'triton.backends.nvidia.driver' (/home/carmocca/git/nightly-venv/lib/python3.10/site-packages/triton/backends/nvidia/driver.py)Also, you would want to update L98 which also imports this once there' a working solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for unsloth.
I happened to have triton 3.x dev installed, it seems the import location for libcuda_dirs changed.
With this change, one can import unsloth with newer triton.
Thank you again.