Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix libcuda_dirs import for triton 3.0 #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix libcuda_dirs import for triton 3.0 #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion unsloth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@
# Try loading bitsandbytes and triton
import bitsandbytes as bnb
import triton
from triton.common.build import libcuda_dirs
triton_version = triton.__version__.split(".")
triton_major = int(triton_version[0])
if triton_major >= 3:
from triton.backends.nvidia.driver import libcuda_dirs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't work for me with pytorch-triton==3.0.0+901819d2b6:

    import unsloth
  File "/home/carmocca/git/unsloth/unsloth/__init__.py", line 64, in <module>
    from triton.backends.nvidia.driver import libcuda_dirs
ImportError: cannot import name 'libcuda_dirs' from 'triton.backends.nvidia.driver' (/home/carmocca/git/nightly-venv/lib/python3.10/site-packages/triton/backends/nvidia/driver.py)

Also, you would want to update L98 which also imports this once there' a working solution

else:
from triton.common.build import libcuda_dirs

import os
import re
import numpy as np
Expand Down