create turbo-static for compile time graph analysis #8037
+1,146
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
This was referenced Apr 24, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
|
✅ This change can build |
arlyon
force-pushed
the
03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods
branch
from
9f50dd4
to
d49e885
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
ce8e28a
to
e952f37
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
e952f37
to
b0c665b
Compare
arlyon
force-pushed
the
03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods
branch
from
d49e885
to
fbab81c
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
b0c665b
to
096a710
Compare
arlyon
force-pushed
the
03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods
branch
from
fbab81c
to
739c4e3
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
096a710
to
9bb9503
Compare
arlyon
force-pushed
the
03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods
branch
from
739c4e3
to
2671771
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
9bb9503
to
152f2e8
Compare
arlyon
force-pushed
the
03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods
branch
from
2671771
to
3fb2eb1
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
152f2e8
to
fd69cf9
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
fd69cf9
to
332fbfc
Compare
arlyon
changed the base branch from
03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods
to
03-08-add_ability_to_filter_by_value_and_occurences
bgw
reviewed
May 22, 2024
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
003b9b0
to
f0c3166
Compare
arlyon
force-pushed
the
arlyon/turbo-static
branch
from
332fbfc
to
893bee0
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
f0c3166
to
1b49d92
Compare
bgw
approved these changes
May 31, 2024
Comment on lines
+34
to
+46
| fn get_name(item: &CallHierarchyItem) -> String { | ||
| // open file, find range inside, extract text | ||
| let file = fs::read_to_string(item.uri.path()).unwrap(); | ||
| let start = item.selection_range.start; | ||
| let end = item.selection_range.end; | ||
| file.lines() | ||
| .nth(start.line as usize) | ||
| .unwrap() | ||
| .chars() | ||
| .skip(start.character as usize) | ||
| .take(end.character as usize - start.character as usize) | ||
| .collect() | ||
| } |
There was a problem hiding this comment.
I'm assuming the name field of CallHierarchyItem isn't the thing you want? https://docs.rs/lsp-types/latest/lsp_types/struct.CallHierarchyItem.html#structfield.name
Comment on lines
+10
to
+11
| sender: Option<crossbeam_channel::Sender<Message>>, | ||
| receiver: Option<crossbeam_channel::Receiver<Message>>, |
There was a problem hiding this comment.
Minor/FYI, std::sync::mpsc uses crossbeam as of rust 1.67.0: https://blog.rust-lang.org/2023/01/26/Rust-1.67.0.html#stdsyncmpsc-implementation-updated
There used to be some general advice to avoid std::sync::mpsc because the implementation was bad, but now I feel like you don't need to use crossbeam_channel unless you need some features from it.
Comment on lines
+78
to
+97
| pub enum CallingStyle { | ||
| Once, | ||
| #[allow(dead_code)] | ||
| ZeroOrOnce, | ||
| #[allow(dead_code)] | ||
| ZeroOrMore, | ||
| #[allow(dead_code)] | ||
| OneOrMore, | ||
| } | ||
|
|
||
| impl CallingStyle { | ||
| fn bitset(self) -> u8 { | ||
| match self { | ||
| CallingStyle::Once => 0b0010, | ||
| CallingStyle::ZeroOrOnce => 0b011, | ||
| CallingStyle::ZeroOrMore => 0b0111, | ||
| CallingStyle::OneOrMore => 0b0110, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub enum CallingStyle { | |
| Once, | |
| #[allow(dead_code)] | |
| ZeroOrOnce, | |
| #[allow(dead_code)] | |
| ZeroOrMore, | |
| #[allow(dead_code)] | |
| OneOrMore, | |
| } | |
| impl CallingStyle { | |
| fn bitset(self) -> u8 { | |
| match self { | |
| CallingStyle::Once => 0b0010, | |
| CallingStyle::ZeroOrOnce => 0b011, | |
| CallingStyle::ZeroOrMore => 0b0111, | |
| CallingStyle::OneOrMore => 0b0110, | |
| } | |
| } | |
| } | |
| pub enum CallingStyle { | |
| Once = 0b0010, | |
| #[allow(dead_code)] | |
| ZeroOrOnce = 0b0011, | |
| #[allow(dead_code)] | |
| ZeroOrMore = 0b0111, | |
| #[allow(dead_code)] | |
| OneOrMore = 0b0110, | |
| } | |
| impl CallingStyle { | |
| fn bitset(self) -> u8 { | |
| self as u8 | |
| } | |
| } |
You also might not need the #[allow(dead_code)] since fn add should use the enum variants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Closes TURBO-2877