Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags to turbo tasks #8038

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add tags to turbo tasks #8038

wants to merge 2 commits into from

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented Apr 24, 2024

Description

Testing Instructions

Closes TURBO-2878

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:53pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:53pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 2:53pm

Copy link
Contributor Author

arlyon commented Apr 24, 2024

Copy link
Contributor

github-actions bot commented Apr 24, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 24, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

github-actions bot commented Apr 24, 2024

⚠️ This change may fail to build next-swc.

Logs

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=6680b8765277c77ae6f6ae920d15052e90a522c7#517554ee)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.92.8` are: 0.92.10, 0.92.9, 0.92.8

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.92.5`
    ... which satisfies dependency `swc_core = "^0.92.5"` (locked to 0.92.5) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@chris-olszewski
Copy link
Contributor

@arlyon Did you mean to tag Nick and I as reviewers for this PR?

@arlyon
Copy link
Contributor Author

arlyon commented May 21, 2024

No, oops. I tagged you on the other one but I swear I didn't do it twice ... Sorry 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants