Unify sold2 config dataclasses #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnv1
reviewed
May 8, 2024
|
@johnnv1 applied the changes |
johnnv1
approved these changes
May 9, 2024
|
The doctest for kornia/feature/sold2/sold2_detector.py::kornia.feature.sold2.sold2_detector.SOLD2_detector is failling, could you check it? @lappemic |
|
@johnnv1 the docs are ok. I don't understand the other errors (e.g. Tests on CPU (PR) / tests-cpu (MacOS-latest, float32) ...) and also was not able to mitigate them. Do you know what the issue is there? |
tks, these falling cases is some issue with the CI/torch |
johnnv1
approved these changes
May 12, 2024
|
How can i mitigate them? Or how can i finish this PR then? |
|
|
@lappemic could you rebase this one? i removed the CI with the issue |
* chore: remove repetitive words * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix (CI): remove old torch on macos * chore: ensure last pytorch
* [pre-commit.ci] pre-commit suggestions updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2) * fix up031 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: João Gustavo A. Amorim <joaogustavoamorim@gmail.com>
* initial commit * add docs * add tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update docs * correct typing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update tests and docs * change randn to rand * Modify docs indentation * correct docs and remove unused vars * add return_mask * Remove shape in doc * fix docs format --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: edgar <edgar.riba@gmail.com>
cjpurackal
pushed a commit
to cjpurackal/kornia
that referenced
this pull request
May 18, 2024
* refactor: store sold2_detector config dataclasses in utils/structures.py * fix: update path to DetectorCfg in Docstring * Move structures.py and restate import path * Update SOLD2_detector docstring * Add LineMatcherCfg dataclass to structures.py * Update LineMatcherCfg to include line_score * refactor: cfg of SOLD2 and WunschLineMatcher to be dataclasses * my bad... * fix: update WunschLineMatcher initialization * fix: update SOLD2 initialiation * fix: rollback due to inconsistencies with sold2 config to dataclass * chore: remove repetitive words (kornia#2902) * chore: remove repetitive words * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * CI: Drop macos-latest runner for torch 1.9.1 (kornia#2905) * fix (CI): remove old torch on macos * chore: ensure last pytorch * [pre-commit.ci] pre-commit suggestions (kornia#2894) * [pre-commit.ci] pre-commit suggestions updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2) * fix up031 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: João Gustavo A. Amorim <joaogustavoamorim@gmail.com> * feat: in_range filtering (kornia#2895) * initial commit * add docs * add tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update docs * correct typing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update tests and docs * change randn to rand * Modify docs indentation * correct docs and remove unused vars * add return_mask * Remove shape in doc * fix docs format --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: edgar <edgar.riba@gmail.com> --------- Co-authored-by: peicuiping <168072318+peicuiping@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: João Gustavo A. Amorim <joaogustavoamorim@gmail.com> Co-authored-by: Vicent Gilabert <44602177+vgilabert94@users.noreply.github.com> Co-authored-by: edgar <edgar.riba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors the newly introduced dataclasses in PR #2880 to a single file in
kornia/utils/structures.py.Fixes #2093 (according to comment)
ASAP this PR is closed i will refactor
kornia/feature/sold2default_cfg tostructures.pyas well.