fix rustc bug in turbopack-trace-server #8158
Merged
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
This was referenced May 16, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
timneutkens
approved these changes
May 16, 2024
|
✅ This change can build |
arlyon
force-pushed
the
arlyon/turbo-trace-rustc-bug
branch
from
b90554a
to
f61c545
Compare
sokra
approved these changes
May 16, 2024
arlyon
force-pushed
the
arlyon/turbo-trace-rustc-bug
branch
from
f61c545
to
b17a90e
Compare
|
Nice! Hopefully if we can keep an eye on rust-lang/rust#124891 we can revert this once fixed. |
arlyon
force-pushed
the
arlyon/turbo-trace-rustc-bug
branch
from
b17a90e
to
cf109b4
Compare
arlyon
force-pushed
the
arlyon/turbo-trace-rustc-bug
branch
from
cf109b4
to
fca37b6
Compare
tknickman
pushed a commit
that referenced
this pull request
May 21, 2024
### Description unfortunately there is a rustc bug that crashes when the typechecking in run in this crate during compiles for next-swc when using `Either<impl Iterator, impl Iterator>`. Solution is to use a Boxed iterator ### Testing Instructions Existing tests OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unfortunately there is a rustc bug that crashes when the typechecking in run in this crate during compiles for next-swc when using
Either<impl Iterator, impl Iterator>. Solution is to use a Boxed iteratorTesting Instructions
Existing tests OK